-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trustroot testdata generator and embedded data #1325
Conversation
Signed-off-by: Cody Soyland <[email protected]>
Signed-off-by: Cody Soyland <[email protected]>
Signed-off-by: Cody Soyland <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
==========================================
- Coverage 54.33% 54.25% -0.08%
==========================================
Files 44 44
Lines 3839 3839
==========================================
- Hits 2086 2083 -3
- Misses 1539 1541 +2
- Partials 214 215 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @codysoyland. Everything looks good here. Could you add a Makefile target that regenerates the test data?
Signed-off-by: Cody Soyland <[email protected]>
Signed-off-by: Cody Soyland <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @codysoyland
Summary
This PR adds a small program to generate testdata for the trustroot reconciler tests, and uses
go:embed
to include the test data so that it is easier to read and maintain.Fixes #1324
Release Note
Documentation